Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make ToAddress in routeAction nullable #427

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix: Make ToAddress in routeAction nullable #427

merged 2 commits into from
Jun 25, 2024

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Jun 24, 2024 •
edited
Loading

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@codecov Codecov
Copy link

codecov bot commented Jun 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.27%. Comparing base (50031b0) to head (e9aefb3).

Files Patch % Lines
...etwork/balanced/score/lib/structs/RouteAction.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #427   +/-   ##
=========================================
  Coverage     74.27%   74.27%           
  Complexity     1910     1910           
=========================================
  Files           128      128           
  Lines          9121     9121           
  Branches       1105     1105           
=========================================
  Hits           6775     6775           
  Misses         1863     1863           
  Partials        483      483
Flag Coverage Δ
java 74.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntonAndell AntonAndell linked an issue Jun 24, 2024 that may be closed by this pull request
Router fix for usdc to icx swap #426
Closed
@AntonAndell AntonAndell added the bug Something isn't working label Jun 25, 2024
@AntonAndell AntonAndell force-pushed the fix/routeV2-swaps-to-ICX branch from c33e09e to e9aefb3 Compare June 25, 2024 05:58
@AntonAndell AntonAndell merged commit 678f958 into main Jun 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TRSSMG TRSSMG TRSSMG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Router fix for usdc to icx swap
2 participants
@AntonAndell @TRSSMG